Adjust Windows release asset name to match convention#23
Open
fenhl wants to merge 1 commit intoianh:masterfrom
Open
Adjust Windows release asset name to match convention#23fenhl wants to merge 1 commit intoianh:masterfrom
fenhl wants to merge 1 commit intoianh:masterfrom
Conversation
Contributor
|
This should likely be done at the Makefile level and then propagated up. |
Author
|
I'm not too familiar with the Makefile format, would changing the filename in this line accomplish that? Line 20 in d36bf2f |
Contributor
|
Yep, wait for boss panic's opinion though. |
Owner
|
This change would break anything that is currently using the library (om.py, the pareto finder script, maybe other things), so I’m not sure it’s a good idea. Would it be possible to change the zlbb build process to prepend “lib” on Windows? |
Contributor
|
Of course, I thought you guys had talked about this already- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the name of the Windows DLL from
libverify.dlltoverify.dll. This should fix an issue I ran into when attempting to build zlbb on Windows where a helper function (org.gradle.internal.os.OperatingSystem'sgetSharedLibraryNamemethod) is used to determine the platform-appropriate release attachment URL.